From: Gord Thompson <gord@gordthompson.com>
Date: Wed, 2 Oct 2019 20:06:53 +0000 (-0400)
Subject: remove __init__ from MySQLDialect_pyodbc
X-Git-Tag: rel_1_4_0b1~706^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f7fa67de8d2c8825fe299aa775fb7b2e05a81ef3;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

remove __init__ from MySQLDialect_pyodbc

Fixes: #4869

<!-- Provide a general summary of your proposed changes in the Title field above -->

### Description
remove __init__ from MySQLDialect_pyodbc, specifically to get rid of the convert_unicode flag

### Checklist
<!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the PR is submitted, so no need to do everything at once)

-->

This pull request is:

- [ ] A documentation / typographical error fix
	- Good to go, no issue or tests are needed
- [x] A short code fix
	- please include the issue number, and create an issue if none exists, which
	  must include a complete example of the issue.  one line code fixes without an
	  issue and demonstration will not be accepted.
	- Please include: `Fixes: #<issue number>` in the commit message
	- please include tests.   one line code fixes without tests will not be accepted.
- [ ] A new feature implementation
	- please include the issue number, and create an issue if none exists, which must
	  include a complete example of how the feature would look.
	- Please include: `Fixes: #<issue number>` in the commit message
	- please include tests.

**Have a nice day!**

Closes: #4884
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/4884
Pull-request-sha: d63550aca4ff9321e094fcb02105ecfa9d1076e1

Change-Id: I8986f7bf6de4d2b221106eded63576439d467c0f
---

diff --git a/lib/sqlalchemy/dialects/mysql/pyodbc.py b/lib/sqlalchemy/dialects/mysql/pyodbc.py
index e8d2034a17..17021812c5 100644
--- a/lib/sqlalchemy/dialects/mysql/pyodbc.py
+++ b/lib/sqlalchemy/dialects/mysql/pyodbc.py
@@ -45,11 +45,6 @@ class MySQLDialect_pyodbc(PyODBCConnector, MySQLDialect):
 
     pyodbc_driver_name = "MySQL"
 
-    def __init__(self, **kw):
-        # deal with http://code.google.com/p/pyodbc/issues/detail?id=25
-        kw.setdefault("convert_unicode", True)
-        super(MySQLDialect_pyodbc, self).__init__(**kw)
-
     def _detect_charset(self, connection):
         """Sniff out the character set in use for connection results."""