From: Michal Privoznik Date: Wed, 12 Aug 2015 08:34:39 +0000 (+0200) Subject: networkBandwidthGenericChecks: Drop useless check X-Git-Tag: v1.2.19-rc1~84 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f7fba69bd7a6756af75ebfc60da1f8e4e948977e;p=thirdparty%2Flibvirt.git networkBandwidthGenericChecks: Drop useless check There's a check right at the beginning of the function that shortcuts if the function was called over all NULL arguments. However, this was meant just as a fool-proof check so that we don't crash if function is used in a bad manner. Anyway, it makes Coverity unhappy as it then thinks any of the arguments could be NULL. Well, with the current state of the code it can't. Signed-off-by: Michal Privoznik --- diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index f57c4003d7..c343e5bdd2 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -4960,9 +4960,6 @@ networkBandwidthGenericChecks(virDomainNetDefPtr iface, virNetDevBandwidthPtr ifaceBand; unsigned long long old_floor, new_floor; - if (!iface && !newBandwidth) - return false; - if (virDomainNetGetActualType(iface) != VIR_DOMAIN_NET_TYPE_NETWORK) { /* This is not an interface that's plugged into a network. * We don't care. Thus from our POV bandwidth change is allowed. */