From: Martin Schwenke <martin@meltin.net>
Date: Thu, 4 Aug 2016 05:58:50 +0000 (+1000)
Subject: ctdb-tests: Fix CID 1361816 Buffer not null terminated (BUFFER_SIZE_WARNING)
X-Git-Tag: tevent-0.9.30~198
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f802a11d3ba808baba6cb2d31d706952df1e3159;p=thirdparty%2Fsamba.git

ctdb-tests: Fix CID 1361816 Buffer not null terminated (BUFFER_SIZE_WARNING)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12110

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
---

diff --git a/ctdb/tests/src/fake_ctdbd.c b/ctdb/tests/src/fake_ctdbd.c
index 35bca88b286..c27af4a4d7a 100644
--- a/ctdb/tests/src/fake_ctdbd.c
+++ b/ctdb/tests/src/fake_ctdbd.c
@@ -2196,8 +2196,8 @@ static void control_get_ifaces(TALLOC_CTX *mem_ctx,
 			.link_state = iface->link_up,
 			.references = iface->references,
 		};
-		strncpy(iface_list->iface[i].name, iface->name,
-			CTDB_IFACE_SIZE+2);
+		strlcpy(iface_list->iface[i].name, iface->name,
+			sizeof(iface_list->iface[i].name));
 	}
 
 	reply.rdata.data.iface_list = iface_list;