From: Tom Hromatka Date: Tue, 27 Apr 2021 16:32:10 +0000 (+0000) Subject: api.c: Fix strncpy() truncation warning X-Git-Tag: v2.0~2^2~14 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f804a5de6f3aaa17c33ee1a97ea7e5be6fa853d5;p=thirdparty%2Flibcgroup.git api.c: Fix strncpy() truncation warning Fix the following strncpy() string truncation warning: In function ‘strncpy’, inlined from ‘cgroup_parse_rules_file’ at api.c:798:3: /usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: ‘__builtin___strncpy_chk’ output may be truncated copying between 0 and 255 bytes from a string of length 255 [-Wstringop-truncation] 106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Tom Hromatka --- diff --git a/src/api.c b/src/api.c index 77c6838b..4e6e3b9e 100644 --- a/src/api.c +++ b/src/api.c @@ -796,6 +796,8 @@ static int cgroup_parse_rules_file(char *filename, bool cache, uid_t muid, len_username = min(len_username, sizeof(newrule->username) - 1); strncpy(newrule->username, user, len_username); + newrule->username[sizeof(newrule->username) - 1] = '\0'; + if (len_procname) { newrule->procname = strdup(procname); if (!newrule->procname) {