From: Victor Julien <vjulien@oisf.net>
Date: Sat, 28 Jan 2023 10:40:53 +0000 (+0100)
Subject: detect/tls.certs: improve buffer init logic
X-Git-Tag: suricata-7.0.0-rc1~30
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f834377c5f40d132c392f639575b9be6d58c6aa7;p=thirdparty%2Fsuricata.git

detect/tls.certs: improve buffer init logic
---

diff --git a/src/detect-tls-certs.c b/src/detect-tls-certs.c
index c4088222c8..21fb5c8baa 100644
--- a/src/detect-tls-certs.c
+++ b/src/detect-tls-certs.c
@@ -143,8 +143,8 @@ static InspectionBuffer *TlsCertsGetData(DetectEngineThreadCtx *det_ctx,
 
     InspectionBuffer *buffer =
             InspectionBufferMultipleForListGet(det_ctx, list_id, cbdata->local_id);
-    if (buffer == NULL)
-        return NULL;
+    if (buffer == NULL || buffer->initialized)
+        return buffer;
 
     const SSLState *ssl_state = (SSLState *)f->alstate;
     const SSLStateConnp *connp;
@@ -204,7 +204,7 @@ static uint8_t DetectEngineInspectTlsCerts(DetectEngineCtx *de_ctx, DetectEngine
             return DETECT_ENGINE_INSPECT_SIG_MATCH;
         }
 
-	cbdata.local_id++;
+        cbdata.local_id++;
     }
 
     return DETECT_ENGINE_INSPECT_SIG_NO_MATCH;