From: Rico Tzschichholz <ricotz@ubuntu.com>
Date: Mon, 2 Mar 2020 20:05:38 +0000 (+0100)
Subject: vala: Don't create temp-variable for array concatenation expression
X-Git-Tag: 0.48.0~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f8676a6584d5b67ac76e132061a9df5d92258b0f;p=thirdparty%2Fvala.git

vala: Don't create temp-variable for array concatenation expression

Found by scan-build
---

diff --git a/vala/valaassignment.vala b/vala/valaassignment.vala
index 72f150314..abeca56dd 100644
--- a/vala/valaassignment.vala
+++ b/vala/valaassignment.vala
@@ -427,6 +427,8 @@ public class Vala.Assignment : Expression {
 		if (binary != null && binary.left.value_type is ArrayType) {
 			if (binary.operator == BinaryOperator.PLUS) {
 				if (left.symbol_reference == binary.left.symbol_reference) {
+					// Allow direct access to array variable
+					binary.left.lvalue = true;
 					return true;
 				}
 			}