From: Daniel P. Berrange <berrange@redhat.com>
Date: Thu, 30 Jun 2011 14:04:23 +0000 (+0100)
Subject: Fix uninitialized value in QEMU monitor FD sending code
X-Git-Tag: v0.9.3~35
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f870c99b4583db0e74b33c9334f195f4feed304b;p=thirdparty%2Flibvirt.git

Fix uninitialized value in QEMU monitor FD sending code

The 'char control[CMSG_SPACE(sizeof(int))];' was not being
wiped, so could potentially contain uninitialized bytes.
While this was harmless in this case, it caused complaints
from valgrind

* src/qemu/qemu_monitor.c: memset 'control' variable
  in qemuMonitorIOWriteWithFD
---

diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index e995d97814..85732621a5 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@ -383,6 +383,7 @@ qemuMonitorIOWriteWithFD(qemuMonitorPtr mon,
     struct cmsghdr *cmsg;
 
     memset(&msg, 0, sizeof(msg));
+    memset(control, 0, sizeof(control));
 
     iov[0].iov_base = (void *)data;
     iov[0].iov_len = len;