From: Willy Tarreau <w@1wt.eu>
Date: Thu, 24 Nov 2022 14:35:17 +0000 (+0100)
Subject: CLEANUP: qpack: fix format string in debugging code (int signedness)
X-Git-Tag: v2.7-dev10~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f87bb23acbf0c58fa7456d470feb95d2d0865a2c;p=thirdparty%2Fhaproxy.git

CLEANUP: qpack: fix format string in debugging code (int signedness)

In issue #1939, Ilya mentions that cppchecks warned about use of "%d" to
report the QPACK table's index that's locally stored as an unsigned int.
While technically valid, this will never cause any trouble since indexes
are always small positive values, but better use %u anyway to silence
this warning.
---

diff --git a/src/qpack-tbl.c b/src/qpack-tbl.c
index 6713f6dd39..09f01157f2 100644
--- a/src/qpack-tbl.c
+++ b/src/qpack-tbl.c
@@ -154,7 +154,7 @@ void qpack_dht_dump(FILE *out, const struct qpack_dht *dht)
 
 	for (i = HPACK_SHT_SIZE; i < HPACK_SHT_SIZE + dht->used; i++) {
 		slot = (qpack_get_dte(dht, i - HPACK_SHT_SIZE + 1) - dht->dte);
-		fprintf(out, "idx=%d slot=%u name=<%s> value=<%s> addr=%u-%u\n",
+		fprintf(out, "idx=%u slot=%u name=<%s> value=<%s> addr=%u-%u\n",
 			i, slot,
 			istpad(name, qpack_idx_to_name(dht, i)).ptr,
 			istpad(value, qpack_idx_to_value(dht, i)).ptr,