From: Tim Duesterhus <tim@bastelstu.be>
Date: Sat, 20 Nov 2021 13:39:47 +0000 (+0100)
Subject: CLEANUP: sock: Wrap `accept4_broken = 1` into additional parenthesis
X-Git-Tag: v2.5.0~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f897fc99bd3347a2dc8b04f5f8e7982f1c94e996;p=thirdparty%2Fhaproxy.git

CLEANUP: sock: Wrap `accept4_broken = 1` into additional parenthesis

This makes it clear to static analysis tools that this assignment is
intentional and not a mistyped comparison.
---

diff --git a/src/sock.c b/src/sock.c
index e3d4a6e4c1..f11c5b0c4a 100644
--- a/src/sock.c
+++ b/src/sock.c
@@ -74,7 +74,7 @@ struct connection *sock_accept_conn(struct listener *l, int *status)
 	    (((cfd = accept4(l->rx.fd, (struct sockaddr*)addr, &laddr,
 	                     SOCK_NONBLOCK | (master ? SOCK_CLOEXEC : 0))) == -1) &&
 	     (errno == ENOSYS || errno == EINVAL || errno == EBADF) &&
-	     (accept4_broken = 1)))
+	     ((accept4_broken = 1))))
 #endif
 	{
 		laddr = sizeof(*conn->src);