From: Noel Power <noel.power@suse.com>
Date: Fri, 9 Aug 2019 15:00:35 +0000 (+0100)
Subject: s3/libsmb: clang: Fix 'warning: Value stored to 'status' is never read'
X-Git-Tag: tevent-0.10.1~120
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f8b5c47ad51f8ee727122964099b1b3dc36028d9;p=thirdparty%2Fsamba.git

s3/libsmb: clang: Fix 'warning: Value stored to 'status' is never read'

Fixes:

source3/libsmb/namequery.c:2938:2: warning: Value stored to 'status' is never read <--[clang]
        status = NT_STATUS_OK;
        ^        ~~~~~~~~~~~~

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/source3/libsmb/namequery.c b/source3/libsmb/namequery.c
index 5c93c60a371..5d4fca70b20 100644
--- a/source3/libsmb/namequery.c
+++ b/source3/libsmb/namequery.c
@@ -2916,16 +2916,16 @@ NTSTATUS resolve_name_list(TALLOC_CTX *ctx,
 		}
 	}
 	if (num_entries == 0) {
-		SAFE_FREE(ss_list);
-		return NT_STATUS_BAD_NETWORK_NAME;
+		status = NT_STATUS_BAD_NETWORK_NAME;
+		goto done;
 	}
 
 	*return_ss_arr = talloc_array(ctx,
 				struct sockaddr_storage,
 				num_entries);
 	if (!(*return_ss_arr)) {
-		SAFE_FREE(ss_list);
-		return NT_STATUS_NO_MEMORY;
+		status = NT_STATUS_NO_MEMORY;
+		goto done;
 	}
 
 	for (i=0, num_entries = 0; i<count; i++) {
@@ -2937,9 +2937,9 @@ NTSTATUS resolve_name_list(TALLOC_CTX *ctx,
 
 	status = NT_STATUS_OK;
 	*p_num_entries = num_entries;
-
+done:
 	SAFE_FREE(ss_list);
-	return NT_STATUS_OK;
+	return status;
 }
 
 /********************************************************