From: Aidan Van Dyk <aidan@ifax.com>
Date: Wed, 14 Mar 2007 18:14:06 +0000 (+0000)
Subject: Add some comments as to why we don't want to use the modem's line count
X-Git-Tag: HYLAFAX-4_4_0BETA1~134
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f8d096af1700a88eba8217d9bfd2ef7fb089745e;p=thirdparty%2FHylaFAX.git

Add some comments as to why we don't want to use the modem's line count

From Lee:
|  commit b8062c0f76e3d3c37389aa07c950470bb41cec31
|  Author: Lee Howard <faxguy@howardsilvan.com>
|  Date:   Sat Dec 23 00:31:40 2006 +0000
|
|      Add some more comments as to why we don't want to use the modem's line count.
---

diff --git a/faxd/Class2Recv.c++ b/faxd/Class2Recv.c++
index ff60ac1c..460dca67 100644
--- a/faxd/Class2Recv.c++
+++ b/faxd/Class2Recv.c++
@@ -351,7 +351,12 @@ Class2Modem::parseFPTS(TIFF* tif, const char* cp, int& ppr)
 
 	/*
 	 * In practice we cannot trust the modem line count when we're 
-	 * not using ECM due to transmission errors.
+	 * not using ECM due to transmission errors and also due to
+	 * bugs in the modems' own decoders (like MMR).
+	 *
+	 * Furthermore, there exists a discrepancy between many modem's
+	 * behaviors and the specification.  Some give lc in hex and 
+	 * others in decimal, and so this would further complicate things.
 	 */
 	if (!conf.class2UseLineCount) {
 	    lc = getRecvEOLCount();