From: Nicholas Nethercote <njn@valgrind.org>
Date: Fri, 14 Aug 2009 02:12:54 +0000 (+0000)
Subject: Enable Helgrind tests on Darwin -- only 4 of them fail on my machine.
X-Git-Tag: svn/VALGRIND_3_5_0~46
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f8dfb1aa98d73558f63bdf662ca6247cee69031d;p=thirdparty%2Fvalgrind.git

Enable Helgrind tests on Darwin -- only 4 of them fail on my machine.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10804
---

diff --git a/Makefile.am b/Makefile.am
index cdb156738b..43ac061ceb 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -17,18 +17,10 @@ EXP_TOOLS = 	exp-ptrcheck \
 
 # DDD: once all tools work on Darwin, TEST_TOOLS and TEST_EXP_TOOLS can be
 # replaced with TOOLS and EXP_TOOLS.
+TEST_TOOLS = $(TOOLS)
 if !VGCONF_OS_IS_DARWIN
-  TEST_TOOLS = $(TOOLS)
   TEST_EXP_TOOLS = $(EXP_TOOLS)
 else
-  TEST_TOOLS =	memcheck \
-		cachegrind \
-		callgrind \
-		massif \
-		lackey \
-		none \
-		drd
-
   TEST_EXP_TOOLS = exp-bbv
 endif
 
diff --git a/NEWS b/NEWS
index 3b06382b9c..2ab586ddca 100644
--- a/NEWS
+++ b/NEWS
@@ -1,8 +1,8 @@
 
-Release 3.5.0 (???)
+Release 3.5.0 (XXX)
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-* Mac OS X is now supported.  (Note that Mac OS X is often called "Darwin"
-  because that is the name of the OS core.)  
+* Valgrind now runs on Mac OS X.  (Note that Mac OS X is sometimes called
+  "Darwin" because that is the name of the OS core.)  
 
   Supported machines:
   - x86 machines are supported fairly well.
@@ -13,14 +13,9 @@ Release 3.5.0 (???)
     common.
 
   Things that don't work:
-  - Helgrind and Ptrcheck
+  - Ptrcheck
   - Objective-C garbage collection
   - --db-attach=yes
-  - Messages like the following indicate a mismatch between Valgrind's
-    memory map and the kernel. Occasional failures are expected in
-    multithreaded programs. If the failure repeats for the same address
-    range, then there may be a problem causing false errors or crashes.
-        sync check at ...: FAILED
   - If you have Rogue Amoeba's "Instant Hijack" program installed, Valgrind
     will fail with a SIGTRAP at start-up.  This is apparently Instant
     Hijack's fault.  See https://bugs.kde.org/show_bug.cgi?id=193917 for
@@ -29,6 +24,8 @@ Release 3.5.0 (???)
   Usage notes:
   - You will likely find --dsymutil=yes a useful option, as error messages may
     be imprecise without it.
+  - The Mac OS X support is new and therefore will be less robust than the
+    Linux support.  Please report any bugs you find.
 
   Many thanks to Greg Parker for developing this port over several years.
 
diff --git a/helgrind/tests/Makefile.am b/helgrind/tests/Makefile.am
index d17685d321..602ea3213a 100644
--- a/helgrind/tests/Makefile.am
+++ b/helgrind/tests/Makefile.am
@@ -69,6 +69,8 @@ EXTRA_DIST = \
 	tc24_nonzero_sem.vgtest tc24_nonzero_sem.stdout.exp \
 		tc24_nonzero_sem.stderr.exp
 
+# XXX: tc18_semabuse uses operations that are unsupported on Darwin.  It
+# should be conditionally compiled like tc20_verifywrap is.
 check_PROGRAMS = \
 	hg01_all_ok \
 	hg02_deadlock \
diff --git a/helgrind/tests/tc20_verifywrap.vgtest b/helgrind/tests/tc20_verifywrap.vgtest
index 7683e8a7e5..2accc94f43 100644
--- a/helgrind/tests/tc20_verifywrap.vgtest
+++ b/helgrind/tests/tc20_verifywrap.vgtest
@@ -1,2 +1,3 @@
+prereq: test -e tc20_verifywrap
 prog: tc20_verifywrap
 vgopts: --read-var-info=yes
diff --git a/helgrind/tests/tc22_exit_w_lock.vgtest b/helgrind/tests/tc22_exit_w_lock.vgtest
index 4f85dd53dd..2471541bab 100644
--- a/helgrind/tests/tc22_exit_w_lock.vgtest
+++ b/helgrind/tests/tc22_exit_w_lock.vgtest
@@ -1 +1,2 @@
+prereq: test -e tc22_exit_w_lock
 prog: tc22_exit_w_lock