From: Victor Stinner Date: Mon, 2 Oct 2023 15:48:42 +0000 (+0200) Subject: [3.12] gh-108963: using random to generate unique string in sys.intern test … (#110216) X-Git-Tag: v3.12.1~407 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f911d7ecd99c4f0b67131b24b286a569c54c9655;p=thirdparty%2FPython%2Fcpython.git [3.12] gh-108963: using random to generate unique string in sys.intern test … (#110216) gh-108963: using random to generate unique string in sys.intern test (#109491) (cherry picked from commit 44b1e4ea4842c6cdc1bedba7aaeb93f236b3ec08) Co-authored-by: AN Long --- diff --git a/Lib/test/test_sys.py b/Lib/test/test_sys.py index c3e9f9c40681..0b8529a9b6ab 100644 --- a/Lib/test/test_sys.py +++ b/Lib/test/test_sys.py @@ -4,6 +4,7 @@ import gc import locale import operator import os +import random import struct import subprocess import sys @@ -19,10 +20,6 @@ import unittest import warnings -# count the number of test runs, used to create unique -# strings to intern in test_intern() -INTERN_NUMRUNS = 0 - DICT_KEY_STRUCT_FORMAT = 'n2BI2n' class DisplayHookTest(unittest.TestCase): @@ -685,10 +682,8 @@ class SysModuleTest(unittest.TestCase): self.assertEqual(sys.__stdout__.encoding, sys.__stderr__.encoding) def test_intern(self): - global INTERN_NUMRUNS - INTERN_NUMRUNS += 1 self.assertRaises(TypeError, sys.intern) - s = "never interned before" + str(INTERN_NUMRUNS) + s = "never interned before" + str(random.randrange(0, 10**9)) self.assertTrue(sys.intern(s) is s) s2 = s.swapcase().swapcase() self.assertTrue(sys.intern(s2) is s)