From: Stefan Metzmacher <metze@samba.org>
Date: Wed, 23 Mar 2022 03:17:01 +0000 (+0100)
Subject: s4:kdc: avoid using sdb_entry_ex in hdb_samba4_fetch_kvno()
X-Git-Tag: tevent-0.12.0~290
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f917a20fcee101bf78fdc3c6e39e4c66c756c7fb;p=thirdparty%2Fsamba.git

s4:kdc: avoid using sdb_entry_ex in hdb_samba4_fetch_kvno()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/kdc/hdb-samba4.c b/source4/kdc/hdb-samba4.c
index d10515c2edc..e27b612a0b2 100644
--- a/source4/kdc/hdb-samba4.c
+++ b/source4/kdc/hdb-samba4.c
@@ -243,7 +243,7 @@ static krb5_error_code hdb_samba4_fetch_kvno(krb5_context context, HDB *db,
 					     hdb_entry *entry)
 {
 	struct samba_kdc_db_context *kdc_db_ctx;
-	struct sdb_entry_ex sdb_entry_ex = {};
+	struct sdb_entry sentry = {};
 	krb5_error_code code, ret;
 	uint32_t sflags;
 
@@ -263,7 +263,7 @@ static krb5_error_code hdb_samba4_fetch_kvno(krb5_context context, HDB *db,
 			      principal,
 			      sflags,
 			      kvno,
-			      &sdb_entry_ex.entry);
+			      &sentry);
 	switch (ret) {
 	case 0:
 		code = 0;
@@ -283,8 +283,8 @@ static krb5_error_code hdb_samba4_fetch_kvno(krb5_context context, HDB *db,
 		return ret;
 	}
 
-	ret = sdb_entry_to_hdb_entry(context, &sdb_entry_ex.entry, entry);
-	sdb_free_entry(&sdb_entry_ex);
+	ret = sdb_entry_to_hdb_entry(context, &sentry, entry);
+	sdb_entry_free(&sentry);
 
 	if (code != 0 && ret != 0) {
 		code = ret;