From: Jan Kara Date: Thu, 26 Mar 2026 09:53:59 +0000 (+0100) Subject: bdev: Drop pointless invalidate_inode_buffers() call X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f9480ecf939d67a2e0cc5915a82fb1f3c5fcd1d4;p=thirdparty%2Fkernel%2Flinux.git bdev: Drop pointless invalidate_inode_buffers() call Nobody is calling mark_buffer_dirty_inode() with internal bdev inode and it doesn't make sense for internal bdev inode to have any metadata buffer heads. Just drop the pointless invalidate_inode_buffers() call and consequently the whole bdev_evict_inode() because generic code takes care of the rest. CC: linux-block@vger.kernel.org Signed-off-by: Jan Kara Link: https://patch.msgid.link/20260326095354.16340-47-jack@suse.cz Signed-off-by: Christian Brauner --- diff --git a/block/bdev.c b/block/bdev.c index ed022f8c48c79..bb0ffa3bb4dfb 100644 --- a/block/bdev.c +++ b/block/bdev.c @@ -417,19 +417,11 @@ static void init_once(void *data) inode_init_once(&ei->vfs_inode); } -static void bdev_evict_inode(struct inode *inode) -{ - truncate_inode_pages_final(&inode->i_data); - invalidate_inode_buffers(inode); /* is it needed here? */ - clear_inode(inode); -} - static const struct super_operations bdev_sops = { .statfs = simple_statfs, .alloc_inode = bdev_alloc_inode, .free_inode = bdev_free_inode, .drop_inode = inode_just_drop, - .evict_inode = bdev_evict_inode, }; static int bd_init_fs_context(struct fs_context *fc)