From: Mike Brady <4265913+mikebrady@users.noreply.github.com>
Date: Mon, 3 Oct 2022 16:56:18 +0000 (+0100)
Subject: Only call the volume hook once for each volume event even when the dbus interface... 
X-Git-Tag: 4.1-rc2~1^2~21
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f96fa2f793b8ec5d4465a9a736a30661af6d03d6;p=thirdparty%2Fshairport-sync.git

Only call the volume hook once for each volume event even when the dbus interface is included.
---

diff --git a/rtsp.c b/rtsp.c
index aa48d976..adc9db23 100644
--- a/rtsp.c
+++ b/rtsp.c
@@ -3523,14 +3523,16 @@ void handle_set_parameter_parameter(rtsp_conn_info *conn, rtsp_message *req,
       debug(2, "Connection %d: request to set AirPlay Volume to: %f.", conn->connection_number,
             volume);
       // if we are playing, go ahead and change the volume
-      lock_player();
-      config.airplay_volume = volume;
-      if (playing_conn == conn)
-        player_volume(volume, conn);
-      unlock_player();
 #ifdef CONFIG_DBUS_INTERFACE
       if (dbus_service_is_running()) {
-        shairport_sync_set_volume(shairportSyncSkeleton, config.airplay_volume);
+        shairport_sync_set_volume(shairportSyncSkeleton, volume);
+      } else {
+#endif
+        lock_player();
+        if (playing_conn == conn)
+          player_volume(volume, conn);
+        unlock_player();
+#ifdef CONFIG_DBUS_INTERFACE
       }
 #endif
     } else if (strncmp(cp, "progress: ", strlen("progress: ")) ==