From: James Jones <jejones3141@gmail.com>
Date: Mon, 12 Sep 2022 23:41:47 +0000 (-0500)
Subject: Annotate false positive uninit_use (CID #1503898) (#4719)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f99998b2d6401727002d607afeb25307afa105ea;p=thirdparty%2Ffreeradius-server.git

Annotate false positive uninit_use (CID #1503898) (#4719)

find is uninitialized and only has a small portion of find.addr.inet
set in fr_redis_cluster_pool_by_node_addr(), but then all of find.addr
is assigned to spare->pending_addr, hence coverity complains. It turna
out, though, that cluster_node_connect() only uses the part that did
get set.
---

diff --git a/src/lib/redis/cluster.c b/src/lib/redis/cluster.c
index bc4ce08f5ba..c715d2bb149 100644
--- a/src/lib/redis/cluster.c
+++ b/src/lib/redis/cluster.c
@@ -2053,6 +2053,7 @@ int fr_redis_cluster_pool_by_node_addr(fr_pool_t **pool, fr_redis_cluster_t *clu
 			pthread_mutex_unlock(&cluster->mutex);
 			return -1;
 		}
+		/* coverity[uninit_use] */
 		spare->pending_addr = find.addr;	/* Set the config to be applied */
 		if (cluster_node_connect(cluster, spare) < 0) {
 			pthread_mutex_unlock(&cluster->mutex);