From: Steven Baigal (sbaigal) <sbaigal@cisco.com>
Date: Wed, 5 Apr 2023 18:28:42 +0000 (+0000)
Subject: Pull request #3799: http2_inspect: Snort3 crash due to HTTP2 Stream Re-transmission.
X-Git-Tag: 3.1.59.0~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f9a257ec1c843da910bafcb317ef5b4b4efb03b8;p=thirdparty%2Fsnort3.git

Pull request #3799: http2_inspect: Snort3 crash due to HTTP2 Stream Re-transmission.

Merge in SNORT/snort3 from ~RSHAFIQ/snort3:http2_reload_fix to master

Squashed commit of the following:

commit eec6509dbafa0d13ddb4bd6fd854ccdd806a1172
Author: rshafiq <rshafiq@cisco.com>
Date:   Tue Apr 4 14:37:13 2023 -0400

    http2_inspect: make flow data reload safe
---

diff --git a/src/service_inspectors/http2_inspect/http2_flow_data.cc b/src/service_inspectors/http2_inspect/http2_flow_data.cc
index f4fc989b2..49878e181 100644
--- a/src/service_inspectors/http2_inspect/http2_flow_data.cc
+++ b/src/service_inspectors/http2_inspect/http2_flow_data.cc
@@ -45,7 +45,7 @@ uint64_t Http2FlowData::instance_count = 0;
 #endif
 
 Http2FlowData::Http2FlowData(Flow* flow_) :
-    FlowData(inspector_id),
+    FlowData(inspector_id,(Inspector*)(flow_->assistant_gadget)),
     flow(flow_),
     hi((HttpInspect*)(flow->assistant_gadget)),
     hpack_decoder { Http2HpackDecoder(this, SRC_CLIENT, events[SRC_CLIENT],