From: Andreas Schneider <asn@samba.org>
Date: Thu, 13 Feb 2025 09:31:49 +0000 (+0100)
Subject: python:lsa_utils: Don't use optional arguments for OpenPolicyFallback()
X-Git-Tag: tevent-0.17.0~754
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f9a3fc19f1e212c54351c3f94978e66fceeb8835;p=thirdparty%2Fsamba.git

python:lsa_utils: Don't use optional arguments for OpenPolicyFallback()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15680

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/python/samba/lsa_utils.py b/python/samba/lsa_utils.py
index 043e65f3341..571beb46c85 100644
--- a/python/samba/lsa_utils.py
+++ b/python/samba/lsa_utils.py
@@ -35,8 +35,8 @@ def OpenPolicyFallback(
     system_name: str,
     in_version: int,
     in_revision_info: lsa.revision_info1,
-    sec_qos: bool = False,
-    access_mask: int = 0,
+    sec_qos: bool,
+    access_mask: int,
 ):
     attr = lsa.ObjectAttribute()
     if sec_qos:
diff --git a/python/samba/netcmd/domain/trust.py b/python/samba/netcmd/domain/trust.py
index 0784fa5e282..f39d4814a11 100644
--- a/python/samba/netcmd/domain/trust.py
+++ b/python/samba/netcmd/domain/trust.py
@@ -222,6 +222,7 @@ class DomainTrustCommand(Command):
             b''.decode('utf-8'),
             in_version,
             in_revision_info1,
+            False,
             policy_access
         )
 
diff --git a/python/samba/tests/dcerpc/lsa_utils.py b/python/samba/tests/dcerpc/lsa_utils.py
index d5db0723772..6f77a437125 100644
--- a/python/samba/tests/dcerpc/lsa_utils.py
+++ b/python/samba/tests/dcerpc/lsa_utils.py
@@ -79,7 +79,8 @@ class CreateTrustedDomain(TestCase):
             '',
             in_version,
             in_revision_info1,
-            access_mask=security.SEC_FLAG_MAXIMUM_ALLOWED
+            False,
+            security.SEC_FLAG_MAXIMUM_ALLOWED
         )
         self.assertIsNotNone(pol_handle)
 
@@ -168,7 +169,8 @@ class CreateTrustedDomain(TestCase):
             '',
             in_version,
             in_revision_info1,
-            access_mask=security.SEC_FLAG_MAXIMUM_ALLOWED
+            False,
+            security.SEC_FLAG_MAXIMUM_ALLOWED
         )
         self.assertIsNotNone(pol_handle)
 
diff --git a/python/samba/tests/krb5/kdc_base_test.py b/python/samba/tests/krb5/kdc_base_test.py
index 17877aa8863..1da770e4fe8 100644
--- a/python/samba/tests/krb5/kdc_base_test.py
+++ b/python/samba/tests/krb5/kdc_base_test.py
@@ -454,7 +454,8 @@ class KDCBaseTest(TestCaseInTempDir, RawKerberosTest):
                 b''.decode('utf-8'),
                 in_version,
                 in_revision_info1,
-                access_mask=policy_access
+                False,
+                policy_access
             )
 
             info = conn.QueryInfoPolicy2(policy, lsa.LSA_POLICY_INFO_DNS)