From: Victor Julien <vjulien@oisf.net>
Date: Wed, 27 Apr 2022 19:18:17 +0000 (+0200)
Subject: smtp: minor code cleanup
X-Git-Tag: suricata-7.0.0-beta1~608
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f9a5ceb0d862e30f637c12d45330b443f7f1f27e;p=thirdparty%2Fsuricata.git

smtp: minor code cleanup
---

diff --git a/src/app-layer-smtp.c b/src/app-layer-smtp.c
index 3cc84685a2..6cda7cd8fb 100644
--- a/src/app-layer-smtp.c
+++ b/src/app-layer-smtp.c
@@ -234,7 +234,6 @@ static int SMTPPreProcessCommands(SMTPState *state, Flow *f, AppLayerParserState
 static void SMTPConfigure(void) {
 
     SCEnter();
-    int ret = 0, val;
     intmax_t imval;
     uint32_t content_limit = 0;
     uint32_t content_inspect_min_size = 0;
@@ -244,7 +243,8 @@ static void SMTPConfigure(void) {
     if (config != NULL) {
         ConfNode *extract_urls_schemes = NULL;
 
-        ret = ConfGetChildValueBool(config, "decode-mime", &val);
+        int val;
+        int ret = ConfGetChildValueBool(config, "decode-mime", &val);
         if (ret) {
             smtp_config.decode_mime = val;
         }