From: Jim Meyering <meyering@redhat.com>
Date: Tue, 2 Jun 2009 14:33:49 +0000 (+0200)
Subject: build: make distcheck rules use --enable-gcc-warnings
X-Git-Tag: v7.5~116
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f9bb168f56361d338b736869a6ac30bbed655d9c;p=thirdparty%2Fcoreutils.git

build: make distcheck rules use --enable-gcc-warnings

* dist-check.mk (warn_cflags): Remove definition, now that it's
been subsumed by --enable-gcc-warnings.
(my-distcheck): Use configure with --enable-gcc-warnings and remove
use of $(warn_cflags).
---

diff --git a/dist-check.mk b/dist-check.mk
index 9a32d17d77..3a61572452 100644
--- a/dist-check.mk
+++ b/dist-check.mk
@@ -1,12 +1,5 @@
 # Most of this is probably too coreutils-centric to be useful to other packages.
 
-warn_cflags = -Dlint -O -Werror -Wall -Wformat -Wshadow -Wpointer-arith
-
-# anonymous 'enum's are too useful to forbid.  Without this, we'd get:
-# utimecmp.c:193: error: comparison between 'enum <anonymous>' and \
-# 'enum <anonymous>' when using gcc-4.5.0-20090517.
-warn_cflags += -Wno-enum-compare
-
 bin=bin-$$$$
 
 write_loser = printf '\#!%s\necho $$0: bad path 1>&2; exit 1\n' '$(SHELL)'
@@ -124,9 +117,8 @@ my-distcheck: $(DIST_ARCHIVES) $(local-check)
 	mkdir -p $(t)
 	GZIP=$(GZIP_ENV) $(AMTAR) -C $(t) -zxf $(distdir).tar.gz
 	cd $(t)/$(distdir)				\
-	  && ./configure --disable-nls			\
-	  && $(MAKE) CFLAGS='$(warn_cflags)'		\
-	      AM_MAKEFLAGS='$(null_AM_MAKEFLAGS)'	\
+	  && ./configure --enable-gcc-warnings --disable-nls \
+	  && $(MAKE) AM_MAKEFLAGS='$(null_AM_MAKEFLAGS)' \
 	  && $(MAKE) dvi				\
 	  && $(install-transform-check)			\
 	  && $(my-instcheck)				\