From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Fri, 1 Apr 2022 10:23:59 +0000 (+0200)
Subject: Coverity:
X-Git-Tag: rec-4.7.0-beta1~22^2~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f9bb1d3ff22661dbbf9bfa01ee261690266d5a02;p=thirdparty%2Fpdns.git

Coverity:
1487562 Uninitialized scalar variable
1469603 Uninitialized scalar field
1446991 Uninitialized scalar field
---

diff --git a/pdns/recursordist/rec-main.cc b/pdns/recursordist/rec-main.cc
index 22946968c7..ada446c3e0 100644
--- a/pdns/recursordist/rec-main.cc
+++ b/pdns/recursordist/rec-main.cc
@@ -2270,7 +2270,6 @@ int main(int argc, char** argv)
 {
   g_argc = argc;
   g_argv = argv;
-  g_stats.startupTime = time(0);
   Utility::srandom();
   versionSetProduct(ProductRecursor);
   reportBasicTypes();
diff --git a/pdns/syncres.hh b/pdns/syncres.hh
index 95f1131732..1e37dc6655 100644
--- a/pdns/syncres.hh
+++ b/pdns/syncres.hh
@@ -904,8 +904,8 @@ struct PacketID
   bool inIncompleteOkay{false};
   uint16_t id{0};  // wait for a specific id/remote pair
   uint16_t type{0};             // and this is its type
-  TCPAction highState;
-  IOState lowState;
+  TCPAction highState{TCPAction::DoingRead};
+  IOState lowState{IOState::NeedRead};
 
   bool operator<(const PacketID& b) const
   {
@@ -1003,7 +1003,7 @@ struct RecursorStats
   pdns::stat_t noPacketError;
   pdns::stat_t ignoredCount;
   pdns::stat_t emptyQueriesCount;
-  time_t startupTime;
+  time_t startupTime{time(nullptr)};
   pdns::stat_t dnssecQueries;
   pdns::stat_t dnssecAuthenticDataQueries;
   pdns::stat_t dnssecCheckDisabledQueries;
@@ -1149,7 +1149,7 @@ extern __thread struct timeval g_now;
 
 struct ThreadTimes
 {
-  uint64_t msec;
+  uint64_t msec{0};
   vector<uint64_t> times;
   ThreadTimes& operator+=(const ThreadTimes& rhs)
   {