From: Amos Jeffries <squid3@treenet.co.nz>
Date: Sat, 12 Jul 2008 04:04:12 +0000 (+1200)
Subject: Mark TODO on icap_access with authentication
X-Git-Tag: SQUID_3_1_0_1~49^2~148
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f9cf4ba931e2ffc01707026ed434f69b7e692dd1;p=thirdparty%2Fsquid.git

Mark TODO on icap_access with authentication

icap_access curently treats AUTH_REQUIRED ACL results as a
false-negative 'fail' result. This is not the desired behavior,
but is not bad enough to be treated as an actual bug at this point.
---

diff --git a/src/adaptation/AccessCheck.cc b/src/adaptation/AccessCheck.cc
index 870f610e77..db3586186c 100644
--- a/src/adaptation/AccessCheck.cc
+++ b/src/adaptation/AccessCheck.cc
@@ -123,6 +123,11 @@ Adaptation::AccessCheck::AccessCheckCallbackWrapper(int answer, void *data)
 {
     debugs(93, 8, "AccessCheckCallbackWrapper: answer=" << answer);
     AccessCheck *ac = (AccessCheck*)data;
+
+    /** \todo AYJ 2008-06-12: If answer == ACCESS_REQ_PROXY_AUTH
+     * we should be kicking off an authentication before continuing
+     * with this request. see bug 2400 for details.
+     */
     ac->noteAnswer(answer==ACCESS_ALLOWED);
 }