From: Peter Krempa Date: Tue, 8 Aug 2023 13:53:53 +0000 (+0200) Subject: virStorageBackendLogicalCheckPool: Properly mark empty logical pools as active X-Git-Tag: v9.7.0-rc1~150 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fa1a54baa59d244289ce666f9dc52d9eabca47f1;p=thirdparty%2Flibvirt.git virStorageBackendLogicalCheckPool: Properly mark empty logical pools as active The '/dev' filesystem convenience directory for a LVM volume group is not created when the volume group is empty. The logic in 'virStorageBackendLogicalCheckPool' which is used to see whether a pool is active was first checking presence of the directory, which failed for an empty VG. Since the second step is virStorageBackendLogicalMatchPoolSource which is checking mapping between configured PVs and the VG, we can simply rely on the function to also check presence of the pool. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2228223 Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c index 9462ac6790..6acbc37f18 100644 --- a/src/storage/storage_backend_logical.c +++ b/src/storage/storage_backend_logical.c @@ -624,13 +624,7 @@ static int virStorageBackendLogicalCheckPool(virStoragePoolObj *pool, bool *isActive) { - virStoragePoolDef *def = virStoragePoolObjGetDef(pool); - - /* If we can find the target.path as well as ensure that the - * pool's def source - */ - *isActive = virFileExists(def->target.path) && - virStorageBackendLogicalMatchPoolSource(pool); + *isActive = virStorageBackendLogicalMatchPoolSource(pool); return 0; }