From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Wed, 9 Dec 2020 08:53:06 +0000 (+0100)
Subject: confile_utils: cleanup lxc_macvlan_mode_to_flag()
X-Git-Tag: lxc-5.0.0~330^2~37
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fa204110ac8cd7ce9444313236a54b48756c6412;p=thirdparty%2Flxc.git

confile_utils: cleanup lxc_macvlan_mode_to_flag()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/confile_utils.c b/src/lxc/confile_utils.c
index 156ce829f..aa3599bbb 100644
--- a/src/lxc/confile_utils.c
+++ b/src/lxc/confile_utils.c
@@ -532,9 +532,7 @@ static struct lxc_macvlan_mode {
 
 int lxc_macvlan_mode_to_flag(int *mode, const char *value)
 {
-	size_t i;
-
-	for (i = 0; i < sizeof(macvlan_mode) / sizeof(macvlan_mode[0]); i++) {
+	for (size_t i = 0; i < sizeof(macvlan_mode) / sizeof(macvlan_mode[0]); i++) {
 		if (strcmp(macvlan_mode[i].name, value))
 			continue;
 
@@ -542,7 +540,7 @@ int lxc_macvlan_mode_to_flag(int *mode, const char *value)
 		return 0;
 	}
 
-	return -1;
+	return ret_errno(EINVAL);
 }
 
 char *lxc_macvlan_flag_to_mode(int mode)