From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Tue, 4 Jun 2013 18:31:56 +0000 (-0400)
Subject: and this comment
X-Git-Tag: rel_0_9_0b1~294^2~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fa3d18a47cb6f307b18da880a5f8f4c06a6023b4;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

and this comment
---

diff --git a/lib/sqlalchemy/sql/compiler.py b/lib/sqlalchemy/sql/compiler.py
index d245c781a3..2024666b63 100644
--- a/lib/sqlalchemy/sql/compiler.py
+++ b/lib/sqlalchemy/sql/compiler.py
@@ -1087,6 +1087,10 @@ class SQLCompiler(engine.Compiled):
         cloned = {}
         column_translate = [{}]
 
+        # TODO: should we be using isinstance() for this,
+        # as this whole system won't work for custom Join/Select
+        # subclasses where compilation routines
+        # call down to compiler.visit_join(), compiler.visit_select()
         join_name = sql.Join.__visit_name__
         select_name = sql.Select.__visit_name__