From: Simon Cozens <simon@simon-cozens.org>
Date: Wed, 15 May 2024 13:53:11 +0000 (+0100)
Subject: Relax uniqueness criteria to "unique within a script"
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fa4d9fdafb9f6299775df3e16f5b3b12d8a7d8fb;p=thirdparty%2Fgoogle%2Ffonts.git

Relax uniqueness criteria to "unique within a script"
---

diff --git a/tests/test_data_languages.py b/tests/test_data_languages.py
index 3a8ef6b6e5..25a22dd3c4 100644
--- a/tests/test_data_languages.py
+++ b/tests/test_data_languages.py
@@ -268,7 +268,15 @@ def test_exemplar_parser():
 
 
 def test_language_uniqueness():
-    names = Counter([lang.name for lang in LANGUAGES.values()])
+    names = Counter([])
+    for lang in LANGUAGES.values():
+        # We check that names are unique *within a script* since
+        # when we display them in a menu we segment that menu by
+        # script and then by language
+        if lang.preferred_name:
+            names[lang.script + "/" + lang.preferred_name] += 1
+        else:
+            names[lang.name + "/" + lang.preferred_name] += 1
     if any(count > 1 for count in names.values()):
         duplicates = {name: count for name, count in names.items() if count > 1}
         pytest.fail(f"Duplicate language names: {duplicates}")