From: Nick Porter <nick@portercomputing.co.uk>
Date: Fri, 1 Sep 2023 07:30:13 +0000 (+0100)
Subject: Use consistent return values
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fa7ba73233c154a88205ce56746554649716e089;p=thirdparty%2Ffreeradius-server.git

Use consistent return values
---

diff --git a/src/lib/unlang/call_env.c b/src/lib/unlang/call_env.c
index b5e4eff987b..e304bc53282 100644
--- a/src/lib/unlang/call_env.c
+++ b/src/lib/unlang/call_env.c
@@ -204,7 +204,7 @@ call_env_result_t call_env_value_parse(TALLOC_CTX *ctx, request_t *request, void
 	fr_value_box_t	*vb;
 
 	if (tmpl_out) *tmpl_out = env->tmpl;
-	if (env->tmpl_only) return 0;
+	if (env->tmpl_only) return CALL_ENV_SUCCESS;
 
 	vb = fr_value_box_list_head(tmpl_expanded);
 	if (!vb) {
@@ -212,7 +212,7 @@ call_env_result_t call_env_value_parse(TALLOC_CTX *ctx, request_t *request, void
 			RPEDEBUG("Failed to evaluate required module option %s = %s", env->rule->name, env->tmpl->name);
 			return CALL_ENV_MISSING;
 		}
-		return 0;
+		return CALL_ENV_SUCCESS;
 	}
 
 	/*