From: Volker Lendecke <vl@samba.org>
Date: Tue, 29 Nov 2022 09:48:25 +0000 (+0100)
Subject: auth4: Save lines with talloc_asprintf_addbuf() in authsam_domain_group_filter()
X-Git-Tag: talloc-2.4.0~246
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fa8a657b91c123849eb40f74dbce6974ec04338b;p=thirdparty%2Fsamba.git

auth4: Save lines with talloc_asprintf_addbuf() in authsam_domain_group_filter()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source4/auth/sam.c b/source4/auth/sam.c
index f2e5ced6caf..2b18d4dc3c0 100644
--- a/source4/auth/sam.c
+++ b/source4/auth/sam.c
@@ -310,25 +310,19 @@ static NTSTATUS authsam_domain_group_filter(TALLOC_CTX *mem_ctx,
 	*_filter = NULL;
 
 	filter = talloc_strdup(mem_ctx, "(&(objectClass=group)");
-	if (filter == NULL) {
-		return NT_STATUS_NO_MEMORY;
-	}
 
 	/*
 	 * Skip all builtin groups, they're added later.
 	 */
-	filter = talloc_asprintf_append_buffer(filter,
-				"(!(groupType:1.2.840.113556.1.4.803:=%u))",
-				GROUP_TYPE_BUILTIN_LOCAL_GROUP);
-	if (filter == NULL) {
-		return NT_STATUS_NO_MEMORY;
-	}
+	talloc_asprintf_addbuf(&filter,
+			       "(!(groupType:1.2.840.113556.1.4.803:=%u))",
+			       GROUP_TYPE_BUILTIN_LOCAL_GROUP);
 	/*
 	 * Only include security groups.
 	 */
-	filter = talloc_asprintf_append_buffer(filter,
-				"(groupType:1.2.840.113556.1.4.803:=%u))",
-				GROUP_TYPE_SECURITY_ENABLED);
+	talloc_asprintf_addbuf(&filter,
+			       "(groupType:1.2.840.113556.1.4.803:=%u))",
+			       GROUP_TYPE_SECURITY_ENABLED);
 	if (filter == NULL) {
 		return NT_STATUS_NO_MEMORY;
 	}