From: mkanat%bugzilla.org <>
Date: Fri, 11 Sep 2009 16:07:38 +0000 (+0000)
Subject: Bug 508189: (CVE-2009-3166) [SECURITY] Logging in after changing your password would... 
X-Git-Tag: bugzilla-3.4.2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fab9f888c9ad56f468b686de975e1f5910f3306d;p=thirdparty%2Fbugzilla.git

Bug 508189: (CVE-2009-3166) [SECURITY] Logging in after changing your password would expose your new password in the URL
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=mkanat
---

diff --git a/token.cgi b/token.cgi
index eaadee3e09..2206f6f197 100755
--- a/token.cgi
+++ b/token.cgi
@@ -130,6 +130,8 @@ if ( $action eq 'chgpw' ) {
       || ThrowUserError("require_new_password");
 
     validate_password($password, $cgi->param('matchpassword'));
+    # Make sure that these never show up in the UI under any circumstances.
+    $cgi->delete('password', 'matchpassword');
 }
 
 ################################################################################
@@ -378,6 +380,8 @@ sub confirm_create_account {
 
     my $password = $cgi->param('passwd1') || '';
     validate_password($password, $cgi->param('passwd2') || '');
+    # Make sure that these never show up anywhere in the UI.
+    $cgi->delete('passwd1', 'passwd2');
 
     my $otheruser = Bugzilla::User->create({
         login_name => $login_name,