From: Harlan Stenn <stenn@ntp.org>
Date: Sun, 5 Sep 2010 06:41:15 +0000 (-0400)
Subject: [Bug 1578] Consistently use -lm when needed
X-Git-Tag: NTP_4_2_7P45~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fabb49df79b32f9c7117807f1aea6a33e1bca9e3;p=thirdparty%2Fntp.git

[Bug 1578] Consistently use -lm when needed

bk: 4c833b8bgj7YRgoxJxUhgt3Ve_dthg
---

diff --git a/ChangeLog b/ChangeLog
index 39986a95f..f6e6b1fd1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,4 @@
+* [Bug 1578] Consistently use -lm when needed.
 (4.2.7p44) 2010/08/27 Released by Harlan Stenn <stenn@ntp.org>
 * [Bug 1573] from 4.2.6p3-RC1: Miscalculation of offset in sntp.
 (4.2.7p43) 2010/08/26 Released by Harlan Stenn <stenn@ntp.org>
diff --git a/clockstuff/Makefile.am b/clockstuff/Makefile.am
index 752167861..c4d053246 100644
--- a/clockstuff/Makefile.am
+++ b/clockstuff/Makefile.am
@@ -4,8 +4,7 @@ noinst_PROGRAMS = @PROPDELAY@ @CHUTEST@ @CLKTEST@
 EXTRA_PROGRAMS = propdelay chutest clktest
 
 INCLUDES = -I$(top_srcdir)/include
-# We need -lm (and perhaps $(COMPAT) for propdelay, -lntp for {chu,clk}test
-propdelay_LDADD = -lm ../libntp/libntp.a
+propdelay_LDADD = $(LIBM) ../libntp/libntp.a
 chutest_LDADD = ../libntp/libntp.a
 clktest_LDADD = ../libntp/libntp.a
 ETAGS_ARGS = Makefile.am
diff --git a/configure.ac b/configure.ac
index 313e4bb3c..707fdd0af 100644
--- a/configure.ac
+++ b/configure.ac
@@ -382,6 +382,7 @@ AC_SEARCH_LIBS([MD5Init], [md5 md])
 AC_CHECK_FUNCS([MD5Init])
 
 NTP_LINEEDITLIBS
+NTP_LIB_M
 
 dnl Digital UNIX V4.0 and Solaris 7 have POSIX.1c functions in -lrt
 dnl Solaris 2.6 only has -lposix4; in Solaris 7, this is a symlink to -lrt,
diff --git a/m4/ntp_lib_m.m4 b/m4/ntp_lib_m.m4
new file mode 100644
index 000000000..799c6993a
--- /dev/null
+++ b/m4/ntp_lib_m.m4
@@ -0,0 +1,14 @@
+dnl ######################################################################
+dnl What do we need for math libraries?
+AC_DEFUN([NTP_LIB_M], [
+LIBM=
+case "$host" in
+ *-*-darwin*)
+    ;;
+ *)
+    AC_CHECK_LIB(m, cos, LIBM="-lm")
+    ;;
+esac
+AC_SUBST([LIBM])
+])
+dnl ======================================================================
diff --git a/ntpd/Makefile.am b/ntpd/Makefile.am
index 1415d045a..8e6246ee9 100644
--- a/ntpd/Makefile.am
+++ b/ntpd/Makefile.am
@@ -83,13 +83,8 @@ man_MANS=	$(srcdir)/ntpd.1
 # simulator currently uses ntpd-opts.[ch].  This also means there is no
 # longer a reason to have ntpdbase-opts.def split off of ntpd-opts.def.
 
-# ntpd may need:
-# log10                               refclock_wwv.o
-# sqrt                                ntp_control.o
-# floor                               refclock_wwv.o
-# which are (usually) provided by -lm.
-ntpd_LDADD = $(LDADD) $(LIBOPTS_LDADD) ../libntp/libntp.a -lm @LCRYPTO@ @LSCF@
-ntpdsim_LDADD = $(LDADD) $(LIBOPTS_LDADD) ../libntp/libntpsim.a -lm @LCRYPTO@ @LSCF@
+ntpd_LDADD = $(LDADD) $(LIBOPTS_LDADD) ../libntp/libntp.a $(LIBM) @LCRYPTO@ @LSCF@
+ntpdsim_LDADD = $(LDADD) $(LIBOPTS_LDADD) $(LIBM) ../libntp/libntpsim.a @LCRYPTO@ @LSCF@
 ntpdsim_CFLAGS = $(CFLAGS) -DSIM
 check_y2k_LDADD = $(LDADD) ../libntp/libntp.a
 keyword_gen_LDADD = ../libntp/libntp.a	# we don't want $(LDADD) here
diff --git a/ntpdate/Makefile.am b/ntpdate/Makefile.am
index ea760af9b..06987e466 100644
--- a/ntpdate/Makefile.am
+++ b/ntpdate/Makefile.am
@@ -20,7 +20,7 @@ AM_CPPFLAGS= -I$(top_srcdir)/include -I$(top_srcdir)/lib/isc/include \
 
 # LDADD might need RESLIB and ADJLIB
 LDADD=		version.o ../libntp/libntp.a
-ntpdate_LDADD= $(LDADD) @LCRYPTO@
+ntpdate_LDADD= $(LDADD) $(LIBM) @LCRYPTO@
 DISTCLEANFILES=	.version version.c stamp-v
 noinst_HEADERS=	ntpdate.h
 ETAGS_ARGS=	Makefile.am
diff --git a/ntpq/Makefile.am b/ntpq/Makefile.am
index 5d259b9a8..8393245e9 100644
--- a/ntpq/Makefile.am
+++ b/ntpq/Makefile.am
@@ -12,7 +12,7 @@ AM_CPPFLAGS= -I$(top_srcdir)/include -I$(top_srcdir)/lib/isc/include \
 	-I$(top_srcdir)/lib/isc/unix/include $(LIBOPTS_CFLAGS)
 
 # LDADD might need RESLIB and ADJLIB
-ntpq_LDADD=	version.o $(LIBOPTS_LDADD) ../libntp/libntp.a \
+ntpq_LDADD=	version.o $(LIBOPTS_LDADD) $(LIBM) ../libntp/libntp.a \
 		@EDITLINE_LIBS@ @LCRYPTO@
 noinst_HEADERS=	ntpq.h
 noinst_LIBRARIES=	libntpq.a
diff --git a/sntp/Makefile.am b/sntp/Makefile.am
index 58547af8d..bb0952f9b 100644
--- a/sntp/Makefile.am
+++ b/sntp/Makefile.am
@@ -10,7 +10,7 @@ AM_CPPFLAGS= $(LIBOPTS_CFLAGS) -I$(top_srcdir)/../include \
 	-I$(top_srcdir)/../lib/isc/nothreads/include \
 	-I$(top_srcdir)/../lib/isc/unix/include
 
-LDADD=	$(LIBOPTS_LDADD) -lm ../libntp/libntp.a @LCRYPTO@
+LDADD=	$(LIBOPTS_LDADD) $(LIBM) ../libntp/libntp.a @LCRYPTO@
 
 run_ag=		cd $(srcdir) &&	env PATH="$(abs_builddir):$(PATH)"	\
 		autogen -L ../include --writable
diff --git a/sntp/configure.ac b/sntp/configure.ac
index 0eee100db..05d50798d 100644
--- a/sntp/configure.ac
+++ b/sntp/configure.ac
@@ -134,7 +134,7 @@ AC_PROG_LIBTOOL
 NTP_DIR_SEP
 
 # Checks for libraries.
-
+NTP_LIB_M
 AC_CHECK_FUNC([gethostent], ,
 	[AC_SEARCH_LIBS([gethostent], [nsl], , , [$libxnet -lsocket])])
 AC_CHECK_FUNC([openlog], , 
diff --git a/util/Makefile.am b/util/Makefile.am
index 54d95e861..9f0cedc47 100644
--- a/util/Makefile.am
+++ b/util/Makefile.am
@@ -19,7 +19,7 @@ AM_CPPFLAGS= -I$(top_srcdir)/include -I$(top_srcdir)/lib/isc/include \
 
 # LDADD might need RESLIB and ADJLIB
 LDADD=		../libntp/libntp.a
-tg2_LDADD=	-lm
+tg2_LDADD=	$(LIBM)
 ntp_keygen_SOURCES = ntp-keygen.c ntp-keygen-opts.c ntp-keygen-opts.h
 ntp_keygen_LDADD=	$(LIBOPTS_LDADD) ../libntp/libntp.a @LCRYPTO@