From: Pavel Filipenský <pfilipensky@samba.org>
Date: Thu, 28 Nov 2024 17:32:25 +0000 (+0100)
Subject: s3:vfs_crossrename: crossrename_renameat() needs to return 0 if copy_reg() is successful
X-Git-Tag: samba-4.20.7~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fac7288aff4335880b0d6761f6328eda5f5d53bb;p=thirdparty%2Fsamba.git

s3:vfs_crossrename: crossrename_renameat() needs to return 0 if copy_reg() is successful

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15724

Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 0a9adc85e77bc557bb8be12237fa31c4142dd3d5)
---

diff --git a/source3/modules/vfs_crossrename.c b/source3/modules/vfs_crossrename.c
index 7c0ae94d257..a4f035d3141 100644
--- a/source3/modules/vfs_crossrename.c
+++ b/source3/modules/vfs_crossrename.c
@@ -211,6 +211,7 @@ static int crossrename_renameat(vfs_handle_struct *handle,
 					   smb_fname_src,
 					   dstfsp,
 					   smb_fname_dst);
+		result = 0;
 		if (!NT_STATUS_IS_OK(status)) {
 			errno = map_errno_from_nt_status(status);
 			result = -1;