From: bert hubert <bert.hubert@netherlabs.nl>
Date: Tue, 19 Feb 2019 22:36:50 +0000 (+0100)
Subject: Our ringbuffers in auth were case sensitive, leading to pages FuLl of 0x20 ModUlaTed... 
X-Git-Tag: dnsdist-1.4.0-alpha1~46^2~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fadd04cc6f309111bddb3f42af96575ad0a78700;p=thirdparty%2Fpdns.git

Our ringbuffers in auth were case sensitive, leading to pages FuLl of 0x20 ModUlaTed domains
---

diff --git a/pdns/statbag.cc b/pdns/statbag.cc
index a4b0436f01..adcd35f2ab 100644
--- a/pdns/statbag.cc
+++ b/pdns/statbag.cc
@@ -218,7 +218,7 @@ vector<pair<T, unsigned int> >StatRing<T,Comp>::get() const
 
 void StatBag::declareRing(const string &name, const string &help, unsigned int size)
 {
-  d_rings[name]=StatRing<string>(size);
+  d_rings[name]=StatRing<string, CIStringCompare>(size);
   d_rings[name].setHelp(help);
 }
 
@@ -288,9 +288,9 @@ string StatBag::getRingTitle(const string &name)
 vector<string>StatBag::listRings()
 {
   vector<string> ret;
-  for(map<string,StatRing<string> >::const_iterator i=d_rings.begin();i!=d_rings.end();++i)
+  for(auto i=d_rings.begin();i!=d_rings.end();++i)
     ret.push_back(i->first);
-  for(map<string,StatRing<SComboAddress> >::const_iterator i=d_comborings.begin();i!=d_comborings.end();++i)
+  for(auto i=d_comborings.begin();i!=d_comborings.end();++i)
     ret.push_back(i->first);
 
   return ret;
@@ -301,5 +301,5 @@ bool StatBag::ringExists(const string &name)
   return d_rings.count(name) || d_comborings.count(name);
 }
 
-template class StatRing<std::string>;
+template class StatRing<std::string, CIStringCompare>;
 template class StatRing<SComboAddress>;
diff --git a/pdns/statbag.hh b/pdns/statbag.hh
index b92c6a4371..130c4014fd 100644
--- a/pdns/statbag.hh
+++ b/pdns/statbag.hh
@@ -64,7 +64,7 @@ class StatBag
 {
   map<string, AtomicCounter *> d_stats;
   map<string, string> d_keyDescrips;
-  map<string,StatRing<string> >d_rings;
+  map<string,StatRing<string, CIStringCompare> >d_rings;
   map<string,StatRing<SComboAddress> >d_comborings;
   typedef boost::function<uint64_t(const std::string&)> func_t;
   typedef map<string, func_t> funcstats_t;