From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 17 May 2017 15:26:54 +0000 (-0400)
Subject: don't use i for inner and outer loop.  Found by PVS-Studio
X-Git-Tag: release_3_0_14~28
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=faf5543f2b266158439f9decb4fc38ddb4ce3b8d;p=thirdparty%2Ffreeradius-server.git

don't use i for inner and outer loop.  Found by PVS-Studio
---

diff --git a/src/lib/misc.c b/src/lib/misc.c
index 587482fc7ef..6449b291459 100644
--- a/src/lib/misc.c
+++ b/src/lib/misc.c
@@ -1871,7 +1871,7 @@ static char *mystrtok(char **ptr, char const *sep)
  */
 int fr_get_time(char const *date_str, time_t *date)
 {
-	int		i;
+	int		i, j;
 	time_t		t;
 	struct tm	*tm, s_tm;
 	char		buf[64];
@@ -1928,9 +1928,9 @@ int fr_get_time(char const *date_str, time_t *date)
 			f[0] = f[i];
 			f[i] = p;
 
-			for (i = 0; i < 12; i++) {
-				if (strncasecmp(months[i], f[0], 3) == 0) {
-					tm->tm_mon = i;
+			for (j = 0; j < 12; j++) {
+				if (strncasecmp(months[j], f[0], 3) == 0) {
+					tm->tm_mon = j;
 					break;
 				}
 			}