From: Aram Sargsyan <aram@isc.org>
Date: Mon, 24 Mar 2025 16:34:00 +0000 (+0000)
Subject: Don't call dst_key_free(keyp) on an invalid 'keyp'
X-Git-Tag: v9.21.7~29^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fb160802804aa130f5b1eb8de03f154c512d6a9e;p=thirdparty%2Fbind9.git

Don't call dst_key_free(keyp) on an invalid 'keyp'

After a refactoring in 2e6107008dae09d32e3d34fb5423b3d78c4ff651 the
dst_key_free() call is invalid and can cause an assertion. Remove the
dst_key_free() call.
---

diff --git a/lib/ns/query.c b/lib/ns/query.c
index 218900dcaf4..1a2ee677c4b 100644
--- a/lib/ns/query.c
+++ b/lib/ns/query.c
@@ -2443,8 +2443,6 @@ get_key(ns_client_t *client, dns_db_t *db, dns_rdata_rrsig_t *rrsig,
 			secure = true;
 			break;
 		}
-
-		dst_key_free(keyp);
 	}
 
 	return secure;