From: Nick Porter <nick@portercomputing.co.uk>
Date: Wed, 22 Nov 2023 12:13:33 +0000 (+0000)
Subject: Header attributes are also in the list - no need to debug them twice
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fb2a5bd9e61dbdac0e3e6237c31509873c066ff1;p=thirdparty%2Ffreeradius-server.git

Header attributes are also in the list - no need to debug them twice
---

diff --git a/src/process/dhcpv4/base.c b/src/process/dhcpv4/base.c
index aa0a19fa227..7296b8b8863 100644
--- a/src/process/dhcpv4/base.c
+++ b/src/process/dhcpv4/base.c
@@ -55,7 +55,6 @@ fr_dict_attr_autoload_t process_dhcpv4_dict_attr[] = {
  */
 static void dhcpv4_packet_debug(request_t *request, fr_radius_packet_t *packet, fr_pair_list_t *list, bool received)
 {
-	size_t i;
 #ifdef WITH_IFINDEX_NAME_RESOLUTION
 	char if_name[IFNAMSIZ];
 #endif
@@ -86,21 +85,6 @@ static void dhcpv4_packet_debug(request_t *request, fr_radius_packet_t *packet,
 #endif
 		       );
 
-	/*
-	 *	Print the fields in the header, too.
-	 */
-	RINDENT();
-	for (i = 0; i < dhcp_header_attrs_len; i++) {
-		fr_pair_t *vp;
-
-		if (!*dhcp_header_attrs[i]) continue;
-
-		vp = fr_pair_find_by_da(list, NULL, *dhcp_header_attrs[i]);
-		if (!vp) continue;
-		RDEBUGX(L_DBG_LVL_1, "%pP", vp);
-	}
-	REXDENT();
-
 	if (received || request->parent) {
 		log_request_pair_list(L_DBG_LVL_1, request, NULL, list, NULL);
 	} else {