From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Fri, 25 Apr 2025 16:25:59 +0000 (-0400)
Subject: Ensure insert is always initialised to quiet clang scan
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fb2bfdee41dcdfc7a4318de537ce79d30f2bf6df;p=thirdparty%2Ffreeradius-server.git

Ensure insert is always initialised to quiet clang scan
---

diff --git a/src/lib/server/command.c b/src/lib/server/command.c
index 3f1e91a848..66b9b26cf8 100644
--- a/src/lib/server/command.c
+++ b/src/lib/server/command.c
@@ -101,13 +101,21 @@ static fr_cmd_t *fr_command_find(fr_cmd_t **head, char const *name, fr_cmd_t ***
 {
 	fr_cmd_t *cmd, **where = head;
 
-	if (!head || !name) return NULL;
+	if (!head || !name) {
+		if (insert) *insert = head;
+		return NULL;
+	}
 
 	if (!*head) {
 		if (insert) *insert = head;
 		return NULL;
 	}
 
+	/*
+	 *	Ensure if we exit int he loop insert is initialised
+	 */
+	if (insert) *insert = NULL;
+
 	for (cmd = *head; cmd != NULL; cmd = cmd->next) {
 		int status;