From: Martin Schwenke <martin@meltin.net>
Date: Tue, 15 Feb 2022 08:32:52 +0000 (+1100)
Subject: util: Drop unused variable num_chars
X-Git-Tag: tevent-0.12.0~695
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fb55d84ebb28865059382e760163e71a54685f50;p=thirdparty%2Fsamba.git

util: Drop unused variable num_chars

clang complains:

../../lib/util/genrand_util.c:99:9: error: variable 'num_chars' set but not used [-Werror,-Wunused-but-set-variable]
        size_t num_chars = 0;
               ^

That is, the variable is initialised and incremented but the value is
never used.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
---

diff --git a/lib/util/genrand_util.c b/lib/util/genrand_util.c
index 82085184e82..1ef4e446e18 100644
--- a/lib/util/genrand_util.c
+++ b/lib/util/genrand_util.c
@@ -96,7 +96,6 @@ _PUBLIC_ uint64_t generate_unique_u64(uint64_t veto_value)
 _PUBLIC_ bool check_password_quality(const char *pwd)
 {
 	size_t ofs = 0;
-	size_t num_chars = 0;
 	size_t num_digits = 0;
 	size_t num_upper = 0;
 	size_t num_lower = 0;
@@ -120,7 +119,6 @@ _PUBLIC_ bool check_password_quality(const char *pwd)
 			break;
 		}
 		ofs += len;
-		num_chars += 1;
 
 		if (len == 1) {
 			const char *na = "~!@#$%^&*_-+=`|\\(){}[]:;\"'<>,.?/";