From: Francis Dupont Date: Thu, 22 Sep 2022 16:42:56 +0000 (+0200) Subject: [#1654] Addressed comments, rebasing X-Git-Tag: Kea-2.3.1~10 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fb61393bfee72ea0483dd8a912bf8dafd987f42f;p=thirdparty%2Fkea.git [#1654] Addressed comments, rebasing --- diff --git a/doc/sphinx/arm/hooks-lease-cmds.rst b/doc/sphinx/arm/hooks-lease-cmds.rst index 98815d5a2d..a818230965 100644 --- a/doc/sphinx/arm/hooks-lease-cmds.rst +++ b/doc/sphinx/arm/hooks-lease-cmds.rst @@ -1023,9 +1023,11 @@ backend and write the lease database into a CSV file. They take the path of the file as the ``filename`` argument. If the specified output file is the same as the configured memfile one the backend close and reopen the file in an attempt to synchronize both file and in memory images -of the lease database. +of the lease database. The previous file is renamed by appending ``.bak`` +to its name. .. note:: These commands do not replace the LFC mechanism: they should be used - only in exceptional circumstances. + only in exceptional circumstances, such as when recovering after + running out of disk space. diff --git a/src/hooks/dhcp/lease_cmds/tests/lease_cmds4_unittest.cc b/src/hooks/dhcp/lease_cmds/tests/lease_cmds4_unittest.cc index a5e276f10a..85b3c8a045 100644 --- a/src/hooks/dhcp/lease_cmds/tests/lease_cmds4_unittest.cc +++ b/src/hooks/dhcp/lease_cmds/tests/lease_cmds4_unittest.cc @@ -3139,6 +3139,9 @@ void Lease4CmdsTest::testLease4ConflictingUpdate() { } void Lease4CmdsTest::testLease4Write() { + // lease4-write negative tests. Positive tests are in the + // memfile_lease_mgr_unittest.cc file. + // Initialize lease manager (false = v4, false = don't add leases) initLeaseMgr(false, false);