From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Sat, 4 Oct 2025 22:24:00 +0000 (+0200)
Subject: auth: mech-cram-md5 - Refactor mech_cram_md5_auth_continue()
X-Git-Tag: 2.4.2~310
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fb6fb6d8d89d3f8ce3e87363bb89e5c9ffe07975;p=thirdparty%2Fdovecot%2Fcore.git

auth: mech-cram-md5 - Refactor mech_cram_md5_auth_continue()
---

diff --git a/src/auth/mech-cram-md5.c b/src/auth/mech-cram-md5.c
index 6f8b419866..02cbf205b8 100644
--- a/src/auth/mech-cram-md5.c
+++ b/src/auth/mech-cram-md5.c
@@ -139,20 +139,20 @@ mech_cram_md5_auth_continue(struct auth_request *auth_request,
 			     auth_request);
 	const char *error;
 
-	if (parse_cram_response(request, data, data_size, &error)) {
-		if (auth_request_set_username(auth_request, request->username,
-					      &error)) {
-			auth_request_lookup_credentials(auth_request,
-					"CRAM-MD5", credentials_callback);
-			return;
-		}
+	if (!parse_cram_response(request, data, data_size, &error)) {
+		e_info(auth_request->mech_event, "%s", error);
+		auth_request_fail(auth_request);
+		return;
+	}
+	if (!auth_request_set_username(auth_request, request->username,
+				       &error)) {
+		e_info(auth_request->mech_event, "%s", error);
+		auth_request_fail(auth_request);
+		return;
 	}
 
-	if (error == NULL)
-		error = "authentication failed";
-
-        e_info(auth_request->mech_event, "%s", error);
-	auth_request_fail(auth_request);
+	auth_request_lookup_credentials(auth_request, "CRAM-MD5",
+					credentials_callback);
 }
 
 static void