From: 秦龙飞 <qinlongfei.1@bytedance.com>
Date: Thu, 15 Dec 2022 02:32:21 +0000 (+0800)
Subject: mod-geoip: fix memory leak in geoip_conf_check
X-Git-Tag: v3.4.dev~291
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fb70d71e904713f61849206334cfd2de2ab06ff5;p=thirdparty%2Fknot-dns.git

mod-geoip: fix memory leak in geoip_conf_check
---

diff --git a/src/knot/modules/geoip/geoip.c b/src/knot/modules/geoip/geoip.c
index 0a62bb77be..2257e08bf8 100644
--- a/src/knot/modules/geoip/geoip.c
+++ b/src/knot/modules/geoip/geoip.c
@@ -104,11 +104,14 @@ int geoip_conf_check(knotd_conf_check_args_t *args)
 			return KNOT_EINVAL;
 		}
 		for (size_t i = 0; i < conf.count; i++) {
-			geodb_path_t path;
+			geodb_path_t path = { 0 };
 			if (parse_geodb_path(&path, (char *)conf.multi[i].string) != 0) {
 				args->err_str = "unrecognized geodb-key format";
 				return KNOT_EINVAL;
 			}
+			for (int j = 0; j < GEODB_MAX_PATH_LEN; j++) {
+				free(path.path[j]);
+			}
 		}
 		knotd_conf_free(&conf);
 	}