From: Theodore Ts'o <tytso@mit.edu>
Date: Thu, 11 Feb 2021 15:45:13 +0000 (-0500)
Subject: mke2fs: fix resource leak on error path when creating inodes
X-Git-Tag: v1.46.2~42
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fb874e6ff42bee3ee327afc2651483b83311b445;p=thirdparty%2Fe2fsprogs.git

mke2fs: fix resource leak on error path when creating inodes

Addresses-Coverity-Bug: 1472856
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

diff --git a/misc/create_inode.c b/misc/create_inode.c
index 194b06a2a..67bf94cfd 100644
--- a/misc/create_inode.c
+++ b/misc/create_inode.c
@@ -170,7 +170,7 @@ static errcode_t set_inode_xattr(ext2_filsys fs, ext2_ino_t ino,
 	if (retval) {
 		com_err(__func__, retval,
 			_("while reading xattrs for inode %u"), ino);
-		return retval;
+		goto out;
 	}
 
 	retval = ext2fs_get_mem(size, &list);