From: lpsolit%gmail.com <>
Date: Tue, 26 Jul 2005 21:57:04 +0000 (+0000)
Subject: Bug 300403: New Charts errors out, creates new 'add' user, when Env auth method is... 
X-Git-Tag: bugzilla-2.20rc2~27
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fb8edb63ee733adcdd269692dbf1e0e715e3e118;p=thirdparty%2Fbugzilla.git

Bug 300403: New Charts errors out, creates new 'add' user, when Env auth method is used - Patch by A. Karl Kornel <karl@kornel.name> r=wurblzap a=justdave
---

diff --git a/Bugzilla/Auth/Login/WWW/Env.pm b/Bugzilla/Auth/Login/WWW/Env.pm
index 9853932065..39bea28dfd 100644
--- a/Bugzilla/Auth/Login/WWW/Env.pm
+++ b/Bugzilla/Auth/Login/WWW/Env.pm
@@ -51,8 +51,12 @@ sub login {
     for ($env_id, $env_email, $env_realname) { $_ ||= '' };
     # make sure the email field contains only a valid email address
     my $emailregexp = Param("emailregexp");
-    $env_email =~ /($emailregexp)/;
-    $env_email = $1;
+    if ($env_email =~ /($emailregexp)/) {
+        $env_email = $1;
+    }
+    else {
+        return undef;
+    }
     # untaint the remaining values
     trick_taint($env_id);
     trick_taint($env_realname);