From: Doug Ledford <dledford@redhat.com>
Date: Thu, 24 Jul 2008 22:35:11 +0000 (-0400)
Subject: Clean up usage of open()
X-Git-Tag: mdadm-2.6.8~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fb97b4d691c04d9303571d7eba3cef4a97264e2f;p=thirdparty%2Fmdadm.git

Clean up usage of open()
	Fix on call that passed an invalid mode to open
	Don't pass a third arg unless we also pass O_CREAT
	Use symbolic args for 2nd and 3rd args

Signed-off-by: Doug Ledford <dledford@redhat.com>
---

diff --git a/Create.c b/Create.c
index 84075797..7b1836a3 100644
--- a/Create.c
+++ b/Create.c
@@ -212,7 +212,7 @@ int Create(struct supertype *st, char *mddev, int mdfd,
 		info.array.working_disks++;
 		if (dnum < raiddisks)
 			info.array.active_disks++;
-		fd = open(dname, O_RDONLY|O_EXCL, 0);
+		fd = open(dname, O_RDONLY|O_EXCL);
 		if (fd <0 ) {
 			fprintf(stderr, Name ": Cannot open %s: %s\n",
 				dname, strerror(errno));
@@ -543,7 +543,7 @@ int Create(struct supertype *st, char *mddev, int mdfd,
 				info.disk.minor = 0;
 				info.disk.state = (1<<MD_DISK_FAULTY);
 			} else {
-				fd = open(dv->devname, O_RDONLY|O_EXCL, 0);
+				fd = open(dv->devname, O_RDONLY|O_EXCL);
 				if (fd < 0) {
 					fprintf(stderr, Name ": failed to open %s after earlier success - aborting\n",
 						dv->devname);
diff --git a/Detail.c b/Detail.c
index 2488c03a..2b2111cd 100644
--- a/Detail.c
+++ b/Detail.c
@@ -38,7 +38,7 @@ int Detail(char *dev, int brief, int export, int test, char *homehost)
 	 * GET_ARRAY_INFO and GET_DISK_INFO ioctl calls
 	 */
 
-	int fd = open(dev, O_RDONLY, 0);
+	int fd = open(dev, O_RDONLY);
 	int vers;
 	mdu_array_info_t array;
 	mdu_disk_info_t *disks;
diff --git a/Grow.c b/Grow.c
index c2eae32b..a8194bf0 100644
--- a/Grow.c
+++ b/Grow.c
@@ -686,7 +686,7 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
 			}
 		spares = sra->array.spare_disks;
 		if (backup_file) {
-			fdlist[d] = open(backup_file, O_RDWR|O_CREAT|O_EXCL, 0600);
+			fdlist[d] = open(backup_file, O_RDWR|O_CREAT|O_EXCL, S_IRUSR | S_IWUSR);
 			if (fdlist[d] < 0) {
 				fprintf(stderr, Name ": %s: cannot create backup file %s: %s\n",
 					devname, backup_file, strerror(errno));
diff --git a/Monitor.c b/Monitor.c
index 54193f5c..abc2dbd6 100644
--- a/Monitor.c
+++ b/Monitor.c
@@ -156,7 +156,7 @@ int Monitor(mddev_dev_t devlist,
 			return 1;
 		}
 		close(0);
-		open("/dev/null", 3);
+		open("/dev/null", O_RDWR);
 		dup2(0,1);
 		dup2(0,2);
 		setsid();
diff --git a/Query.c b/Query.c
index 08029642..190ee298 100644
--- a/Query.c
+++ b/Query.c
@@ -37,7 +37,7 @@ int Query(char *dev)
 	 * whether it is an md device and whether it has
 	 * a superblock
 	 */
-	int fd = open(dev, O_RDONLY, 0);
+	int fd = open(dev, O_RDONLY);
 	int vers;
 	int ioctlerr;
 	int superror, superrno;
diff --git a/mdassemble.c b/mdassemble.c
index 9926dde2..b0d87b83 100644
--- a/mdassemble.c
+++ b/mdassemble.c
@@ -57,7 +57,7 @@ mapping_t pers[] = {
 /* from mdopen.c */
 int open_mddev(char *dev, int autof/*unused */)
 {
-	int mdfd = open(dev, O_RDWR, 0);
+	int mdfd = open(dev, O_RDWR);
 	if (mdfd < 0)
 		fprintf(stderr, Name ": error opening %s: %s\n",
 			dev, strerror(errno));
diff --git a/mdopen.c b/mdopen.c
index 448a9eb8..4fbcb484 100644
--- a/mdopen.c
+++ b/mdopen.c
@@ -173,7 +173,7 @@ int open_mddev(char *dev, int autof)
 			must_remove = 1;
 		if (stb.st_mode && !must_remove) {
 			/* looks ok, see if it is available */
-			mdfd = open(dev, O_RDWR, 0);
+			mdfd = open(dev, O_RDWR);
 			if (mdfd < 0) {
 				fprintf(stderr, Name ": error opening %s: %s\n",
 					dev, strerror(errno));
@@ -254,7 +254,7 @@ int open_mddev(char *dev, int autof)
 				make_parts(dev,parts, ci->symlinks);
 		}
 	}
-	mdfd = open(dev, O_RDWR, 0);
+	mdfd = open(dev, O_RDWR);
 	if (mdfd < 0)
 		fprintf(stderr, Name ": error opening %s: %s\n",
 			dev, strerror(errno));