From: Roman Bogorodskiy <bogorodskiy@gmail.com>
Date: Tue, 28 Apr 2015 04:26:44 +0000 (+0400)
Subject: conf: explicitly initialize 'cpumask' variable
X-Git-Tag: v1.2.15-rc2~32
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fb9da19e90075a12aa84e6507e78a5d1efa6101c;p=thirdparty%2Flibvirt.git

conf: explicitly initialize 'cpumask' variable

Build with clang fails with:

  CC       conf/libvirt_conf_la-domain_conf.lo
  conf/domain_conf.c:13377:9: error: variable 'cpumask' is used
  uninitialized whenever 'if' condition is true
  [-Werror,-Wsometimes-uninitialized]
      if (!(tmp = virXMLPropString(node, "cpuset"))) {
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

and many other similar errors regarding the 'cpuset' variable.

Fix by explicitly initializing it with NULL.
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 0b187205d5..957221b72b 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -13342,7 +13342,7 @@ virDomainIOThreadPinDefParseXML(xmlNodePtr node,
 {
     int ret = -1;
     virDomainIOThreadIDDefPtr iothrid;
-    virBitmapPtr cpumask;
+    virBitmapPtr cpumask = NULL;
     xmlNodePtr oldnode = ctxt->node;
     unsigned int iothreadid;
     char *tmp = NULL;