From: Roy Marples <roy@marples.name>
Date: Wed, 23 Sep 2020 12:14:06 +0000 (+0100)
Subject: if: Always warn about ignored interfaces.
X-Git-Tag: v9.3.0~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fbae1f3873b31da041c58cefaa3667fe2282a629;p=thirdparty%2Fdhcpcd.git

if: Always warn about ignored interfaces.
---

diff --git a/src/if.c b/src/if.c
index 2907cc0e..802fe461 100644
--- a/src/if.c
+++ b/src/if.c
@@ -399,7 +399,7 @@ if_check_arphrd(struct interface *ifp, unsigned int active, bool if_noconf)
 		break;
 	case ARPHRD_LOOPBACK:
 	case ARPHRD_PPP:
-		if (if_noconf) {
+		if (if_noconf && active) {
 			logdebugx("%s: ignoring due to interface type and"
 			    " no config",
 			    ifp->name);
@@ -538,8 +538,11 @@ if_discover(struct dhcpcd_ctx *ctx, struct ifaddrs **ifaddrs,
 		    !if_hasconf(ctx, spec.devname));
 
 		/* Don't allow some reserved interface names unless explicit. */
-		if (if_noconf && if_ignore(ctx, spec.devname))
+		if (if_noconf && if_ignore(ctx, spec.devname)) {
+			logdebugx("%s: ignoring due to interface type and"
+			    " no config", spec.devname);
 			active = IF_INACTIVE;
+		}
 
 		ifp = calloc(1, sizeof(*ifp));
 		if (ifp == NULL) {
@@ -584,7 +587,7 @@ if_discover(struct dhcpcd_ctx *ctx, struct ifaddrs **ifaddrs,
 			case IFT_LOOP: /* FALLTHROUGH */
 			case IFT_PPP:
 				/* Don't allow unless explicit */
-				if (if_noconf) {
+				if (if_noconf && active) {
 					logdebugx("%s: ignoring due to"
 					    " interface type and"
 					    " no config",