From: Mohsin Bashir Date: Sat, 3 May 2025 02:01:45 +0000 (-0700) Subject: eth: fbnic: fix `tx_dropped` counting X-Git-Tag: v6.16-rc1~132^2~162 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fbaeb7b0f0ffb660bcc91dd5f96eaf8d99721656;p=thirdparty%2Fkernel%2Fstable.git eth: fbnic: fix `tx_dropped` counting Fix the tracking of rtnl_link_stats.tx_dropped. The counter `tmi.drop.frames` is being double counted whereas, the counter `tti.cm_drop.frames` is being skipped. Fixes: f2957147ae7a ("eth: fbnic: add support for TTI HW stats") Signed-off-by: Jakub Kicinski Signed-off-by: Mohsin Bashir Reviewed-by: Joe Damato Link: https://patch.msgid.link/20250503020145.1868252-1-mohsin.bashr@gmail.com Signed-off-by: Paolo Abeni --- diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c index d699f58dda211..f994cbf1857dd 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c @@ -425,9 +425,9 @@ static void fbnic_get_stats64(struct net_device *dev, /* Record drops from Tx HW Datapath */ tx_dropped += fbd->hw_stats.tmi.drop.frames.value + + fbd->hw_stats.tti.cm_drop.frames.value + fbd->hw_stats.tti.frame_drop.frames.value + - fbd->hw_stats.tti.tbi_drop.frames.value + - fbd->hw_stats.tmi.drop.frames.value; + fbd->hw_stats.tti.tbi_drop.frames.value; for (i = 0; i < fbn->num_tx_queues; i++) { struct fbnic_ring *txr = fbn->tx[i];