From: Michał Kępień <michal@isc.org>
Date: Tue, 13 Mar 2018 10:28:11 +0000 (+0100)
Subject: Fix a zone database reference counting bug in dump_done()
X-Git-Tag: v9.13.0~97^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fbd5658db7cddda76e6c6dd3026952b5a17a70ba;p=thirdparty%2Fbind9.git

Fix a zone database reference counting bug in dump_done()

A typo in commit d39ab7440e introduced a bug in zone database reference
counting which leads to a crash if dumping one version of a slave zone
is not finished by the time transferring a newer version from a master
completes.  Correct the typo to fix reference counting, thus preventing
crashes.
---

diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index a74afcaf532..ea19a8fa2cb 100644
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -10345,7 +10345,7 @@ dump_done(void *arg, isc_result_t result) {
 			dns_db_t *zdb = NULL;
 			if (dns_zone_getdb(zone, &zdb) == ISC_R_SUCCESS) {
 				zone_journal_compact(zone, zdb, serial);
-				dns_db_detach(&db);
+				dns_db_detach(&zdb);
 			}
 		} else if (tresult == ISC_R_SUCCESS) {
 			compact = ISC_TRUE;