From: Daniel P. Berrange <berrange@redhat.com>
Date: Tue, 24 Sep 2013 15:09:36 +0000 (+0100)
Subject: Fix leak in virDomainVcpuPinDefArrayFree
X-Git-Tag: v1.1.3-rc1~42
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fbf8e1c3144739454cebbac8aa4f8b8c5031ee03;p=thirdparty%2Flibvirt.git

Fix leak in virDomainVcpuPinDefArrayFree

If virDomainVcpuPinDefArrayFree is called with def != NULL,
but nvcpupin == 0, then it leaks memory for 'def'. This is
an unusual scenario, but it hits when cleaning up after an
OOM during parsing of XML.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 4110127f92..152672acf1 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -1854,7 +1854,7 @@ virDomainVcpuPinDefArrayFree(virDomainVcpuPinDefPtr *def,
 {
     size_t i;
 
-    if (!def || !nvcpupin)
+    if (!def)
         return;
 
     for (i = 0; i < nvcpupin; i++) {