From: Florian Krohm <florian@eich-krohm.de>
Date: Wed, 29 Aug 2012 17:40:52 +0000 (+0000)
Subject: Fix address computation in IR injection. When loading / storing a
X-Git-Tag: svn/VALGRIND_3_9_0^2~268
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fc10ea40eac9d1fc74c3f9dad20c3fb8870671d2;p=thirdparty%2Fvalgrind.git

Fix address computation in IR injection. When loading / storing a
128-bit value as 2 64-bit values, the two memory locations are 8 bytes
apart. Always. Everywhere. Due to a thinko this was busted on 32-bit
eachines.
Also add an assert that values requiring more than 128 bit are currently
not supported.


git-svn-id: svn://svn.valgrind.org/vex/trunk@2493
---

diff --git a/VEX/priv/ir_inject.c b/VEX/priv/ir_inject.c
index 989dd5290d..1914f4f0fc 100644
--- a/VEX/priv/ir_inject.c
+++ b/VEX/priv/ir_inject.c
@@ -83,12 +83,14 @@ load(IREndness endian, IRType type, HWord haddr)
    IROp concat;
    IRExpr *addr, *next_addr;
 
+   vassert(type == Ity_I1 || sizeofIRType(type) <= 16);
+
    if (VEX_HOST_WORDSIZE == 8) {
       addr = mkU64(haddr);
       next_addr = binop(Iop_Add64, addr, mkU64(8));
    } else if (VEX_HOST_WORDSIZE == 4) {
       addr = mkU32(haddr);
-      next_addr = binop(Iop_Add32, addr, mkU32(4));
+      next_addr = binop(Iop_Add32, addr, mkU32(8));
    } else {
       vpanic("invalid #bytes for address");
    }
@@ -149,12 +151,16 @@ store(IRSB *irsb, IREndness endian, HWord haddr, IRExpr *data)
       next_addr = binop(Iop_Add64, addr, mkU64(8));
    } else if (VEX_HOST_WORDSIZE == 4) {
       addr = mkU32(haddr);
-      next_addr = binop(Iop_Add32, addr, mkU32(4));
+      next_addr = binop(Iop_Add32, addr, mkU32(8));
    } else {
       vpanic("invalid #bytes for address");
    }
 
-   switch (typeOfIRExpr(irsb->tyenv, data)) {
+   IRType type = typeOfIRExpr(irsb->tyenv, data);
+
+   vassert(type == Ity_I1 || sizeofIRType(type) <= 16);
+
+   switch (type) {
    case Ity_I128: high = Iop_128HIto64;   low = Iop_128to64;     goto store128;
    case Ity_F128: high = Iop_F128HItoF64; low = Iop_F128LOtoF64; goto store128;
    case Ity_D128: high = Iop_D128HItoD64; low = Iop_D128LOtoD64; goto store128;